mpmc: Document #583 and add corresponding loom test #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch documents rust-embedded#583 adds failing loom tests to exercise rust-embedded#583 hoping that a future algorithm change can make them pass. The tests are ran in CI but their results is ignored for now as they fail. Ideally the `loom` tests will cover more usage of `mpmc::Queue` in the future and also cover `spsc`.
0xllx0
reviewed
Oct 8, 2025
|
|
||
| #[cfg(not(any(feature = "portable-atomic", loom)))] | ||
| use core::sync::atomic; | ||
| #[cfg(feature = "portable-atomic")] |
There was a problem hiding this comment.
Suggested change
| #[cfg(feature = "portable-atomic")] | |
| #[cfg(all(feature = "portable-atomic", not(loom)))] |
There was a problem hiding this comment.
I don't think it ever makes sense to have loom and portable-atomic running.
Maybe we can add a compile_error! that prevents any use of --cfg loom outside of the expected feature combination.
There was a problem hiding this comment.
Whichever you prefer, I just added the change here since you added the conditional compilation above for core::sync::atomic. Without the conditional compilation selector, or the compile_error it's possible to combine both (though it result in a different error about a name conflict).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch documents the issue reported in #583 and adds failing loom tests to exercise #583 hoping that a future algorithm change can make them pass.
The tests are ran in CI but their results is ignored for now as they fail.
Ideally the
loomtests will cover more usage ofmpmc::Queuein the future and also coverspsc.